Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Send the response data in block of given lenght instead of sending all at once. #35

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

jjnicola
Copy link
Member

No description provided.

@jjnicola jjnicola requested review from janowagner and a team July 24, 2018 06:29
@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #35 into master will decrease coverage by 0.66%.
The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   64.58%   63.92%   -0.67%     
==========================================
  Files           4        4              
  Lines        1138     1153      +15     
==========================================
+ Hits          735      737       +2     
- Misses        403      416      +13
Impacted Files Coverage Δ
ospd/ospd.py 67.58% <11.76%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dbbf76...628d851. Read the comment docs.

@jjnicola jjnicola changed the title Use try/except sending the response in handle_client_stream(). Send the response data in block of given lenght instead of sending al… …l at once. Aug 8, 2018
@jjnicola jjnicola changed the title Send the response data in block of given lenght instead of sending al… …l at once. Send the response data in block of given lenght instead of sending all at once. Aug 8, 2018
@jjnicola jjnicola requested a review from kroosec August 8, 2018 14:56
@jjnicola jjnicola force-pushed the timeout branch 2 times, most recently from 8148eab to 5a9358a Compare September 6, 2018 14:27
…l at once.

This avoids the timeout for long responses.
Use try/except sending the response. The ospd-server will not die in case
of timeout or broken pipe (e.g. the client does not responde or was killed).
@kroosec kroosec merged commit dad66be into greenbone:master Sep 7, 2018
@jjnicola jjnicola deleted the timeout branch September 26, 2018 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants