Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Use empty string instead of None for credentials value #335

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

jjnicola
Copy link
Member

What:
Set empty string as value when there is an credential param without value

Why:
The string "None" was sent as preference value instead of the empty string.

How:
Run a scan with an snmp credential without community. With this patch, you should not see a result indicating failure for snmp v1|2c. Before, a result was shown, as the script checked the snmp with community "None"

Checklist:

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #335 into ospd-20.08 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           ospd-20.08     #335   +/-   ##
===========================================
  Coverage       73.47%   73.47%           
===========================================
  Files              23       23           
  Lines            2571     2571           
===========================================
  Hits             1889     1889           
  Misses            682      682           
Impacted Files Coverage Δ
ospd/protocol.py 88.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6650020...bb9e43c. Read the comment docs.

@jjnicola jjnicola merged commit 6f25851 into greenbone:ospd-20.08 Oct 23, 2020
@jjnicola jjnicola deleted the snmp-cred branch October 23, 2020 06:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants