Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Improve log and queued scans handling #279

Merged
merged 7 commits into from
Jun 9, 2020

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Jun 8, 2020

No description provided.

Add log when the max queued scans limit has been reached.
Also a message if the scan was queued successfully and inform the position of the scan in the queue.
@jjnicola jjnicola marked this pull request as draft June 8, 2020 15:22
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #279 into master will increase coverage by 0.11%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
+ Coverage   74.92%   75.04%   +0.11%     
==========================================
  Files          22       22              
  Lines        2469     2480      +11     
==========================================
+ Hits         1850     1861      +11     
  Misses        619      619              
Impacted Files Coverage Δ
ospd/main.py 0.00% <0.00%> (ø)
ospd/parser.py 88.50% <ø> (ø)
ospd/ospd.py 75.80% <85.00%> (+0.43%) ⬆️
ospd/command/command.py 87.65% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074f323...0fb354e. Read the comment docs.

@jjnicola jjnicola marked this pull request as ready for review June 9, 2020 06:24
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@bjoernricks bjoernricks merged commit 2082fec into greenbone:master Jun 9, 2020
@jjnicola jjnicola deleted the log-improve branch June 24, 2020 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants