This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
[ospd-2.0] Fix set permission on unix socket. #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ospd-2.0 #157 +/- ##
=========================================
Coverage 68.62% 68.62%
=========================================
Files 12 12
Lines 1756 1756
=========================================
Hits 1205 1205
Misses 551 551
Continue to review full report at Codecov.
|
bjoernricks
suggested changes
Oct 16, 2019
ospd/server.py
Outdated
| @@ -217,6 +214,9 @@ def start(self, stream_callback: StreamCallbackType): | |||
| ) | |||
| ) | |||
|
|
|||
| if self.socket_path.exists(): | |||
| os.chmod(str(self.socket_path), self.socket_mode) | |||
There was a problem hiding this comment.
The Path class has chmod method https://docs.python.org/3/library/pathlib.html :-) Not sure why we didn't use that already
Suggested change
| os.chmod(str(self.socket_path), self.socket_mode) | |
| self.socket_path.chmod(self.socket_mode) |
It was trying to set the permissions on the unix socket before creating it.
bjoernricks
approved these changes
Oct 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was trying to set the permissions on the unix socket before creating it.