Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Only the main process can remove the pid file. #128

Merged
merged 2 commits into from
Aug 16, 2019

Conversation

jjnicola
Copy link
Member

This avoid the pid file to be removed when a child process exits.

This avoid the pid file to be removed when a child process exits.
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #128 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   68.74%   68.66%   -0.09%     
==========================================
  Files          12       12              
  Lines        1702     1704       +2     
==========================================
  Hits         1170     1170              
- Misses        532      534       +2
Impacted Files Coverage Δ
ospd/misc.py 74.66% <0%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0da55...1638dfb. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #128 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   68.74%   68.66%   -0.09%     
==========================================
  Files          12       12              
  Lines        1702     1704       +2     
==========================================
  Hits         1170     1170              
- Misses        532      534       +2
Impacted Files Coverage Δ
ospd/misc.py 74.66% <0%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0da55...c24809a. Read the comment docs.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path has an open method :-)

ospd/misc.py Outdated Show resolved Hide resolved
Co-Authored-By: Björn Ricks <[email protected]>
@jjnicola
Copy link
Member Author

I use my administrator privileges to merge this pull request since the change requested/suggested by @bjoernricks was commited.

@jjnicola jjnicola merged commit 834fd2b into greenbone:master Aug 16, 2019
@jjnicola jjnicola deleted the del-pid-file branch August 16, 2019 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants