This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Refactor ospd connection handling #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use more pythonic api by throwing exceptions instead of using return values. Rewrite add_vt to be more readable.
We are using python 3 so no need to derive from object anymore
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 70.03% 70.41% +0.38%
==========================================
Files 10 11 +1
Lines 1595 1636 +41
==========================================
+ Hits 1117 1152 +35
- Misses 478 484 +6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 70.03% 70.28% +0.25%
==========================================
Files 10 11 +1
Lines 1595 1639 +44
==========================================
+ Hits 1117 1152 +35
- Misses 478 487 +9
Continue to review full report at Codecov.
|
Create a clean API for running OSPd via different transport protocols. This will allow to cleanup the OSPDaemon even further.
The python docs advice to use SSLContext wrap_socket insted of the wrap_socket function directly. Actually wrap_socket is only a helper function and uses the SSLContext internally.
jjnicola
approved these changes
Jun 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor ospd to abstract the actual used transport protocol for OSP.