This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Refactor error module #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string conversion will be used to display the error message by default in a traceback.
Extract a more generic OspdError base class from it and rename it to OspdCommandError.
The error class should be imported from the errors module.
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 69.96% 70.09% +0.13%
==========================================
Files 10 10
Lines 1588 1595 +7
==========================================
+ Hits 1111 1118 +7
Misses 477 477
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 69.96% 70.09% +0.13%
==========================================
Files 10 10
Lines 1588 1595 +7
==========================================
+ Hits 1111 1118 +7
Misses 477 477
Continue to review full report at Codecov.
|
It now contains serveral error classes so errors seems to be a better name to me.
jjnicola
approved these changes
Jun 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.