Change: progress calculation #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
force-pushed
the
excluded-hosts
branch
2 times, most recently
from
902645f to
b2e5ad6
Compare
nichtsfrei
force-pushed
the
excluded-hosts
branch
from
b2e5ad6 to
66a8a6e
Compare
|
Is there something I can do to help speed up this PR? |
|
Hi @zenire , |
Ospd receives the excluded hosts count from openvas. In the end, is openvas which knows how many hosts were excluded, after removing duplicated, or those which doesn't satisfy a preference like reverse_lookup_only. However, excluded hosts list (and count) sent to openvas still includes de finished host if a scan is a resumed task . Therefore, still progress calculation adds the finished hosts to total host reported by openvas. For testing, run scans, stop them and resume it. Different targets should be tested, like a network with the reverse_lookup_only preference, excluded hosts, excluded hosts which do not belong to the target list, etc.
Kraemii
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ospd receives the excluded hosts count from openvas. In the end, is openvas which knows how many hosts were excluded, after removing duplicated, or those which doesn't satisfy a preference like reverse_lookup_only.
However, excluded hosts list (and count) sent to openvas still includes de finished host if a scan is a resumed task . Therefore, still progress calculation adds the finished hosts to total host reported by openvas.
For testing, run scans, stop them and resume it. Different targets should be tested, like a network with the reverse_lookup_only preference, excluded hosts, excluded hosts which do not belong to the target list, etc.
DEPENDS ON ; greenbone/openvas-scanner#1528
Why
Fix an issue which produces the scan to be interrupted because a wrong progress calculation.
References
Jira: SC-964
Closes #951
Checklist