Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement function to check if a scan finished cleanly.  #110

Merged
merged 4 commits into from
Sep 18, 2019

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Sep 17, 2019

Also improve/fix stop scan.

Depends on PR greenbone/ospd#133 and PR greenbone/openvas-scanner#390

Also add an internal key to help openvas to find its own scan id.
Wait until the openvas main process exits, before deleting the db from redis.
@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #110 into master will decrease coverage by 0.74%.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   71.31%   70.56%   -0.75%     
==========================================
  Files           4        4              
  Lines         903      914      +11     
==========================================
+ Hits          644      645       +1     
- Misses        259      269      +10
Impacted Files Coverage Δ
ospd_openvas/daemon.py 57.71% <15.38%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 524bc66...4f0b89d. Read the comment docs.

@bjoernricks bjoernricks merged commit 41b97ce into greenbone:master Sep 18, 2019
@jjnicola jjnicola deleted the finished-target branch September 25, 2019 10:25
ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants