Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Check 'reader' for NULL before trying to unreference it during cleanup #997

Merged
merged 3 commits into from
Dec 13, 2021

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Dec 9, 2021

What:
Check 'reader' for NULL before trying to unreference it during cleanup

Why:
To fix the warning: ‘reader’ may be used uninitialized in this function [-Wmaybe-uninitialized]

How:
Build with release flag

Checklist:

  • Tests
  • PR merge commit message adjusted

@jjnicola jjnicola requested a review from a team as a code owner December 9, 2021 08:25
@jjnicola jjnicola enabled auto-merge (squash) December 9, 2021 08:25
@jjnicola jjnicola enabled auto-merge (squash) December 9, 2021 08:26
@jjnicola jjnicola merged commit 0e7d2f3 into main Dec 13, 2021
@jjnicola jjnicola deleted the json-reader branch December 13, 2021 10:05
mergify bot pushed a commit that referenced this pull request Dec 13, 2021
…leanup (#997)

(cherry picked from commit 0e7d2f3)

# Conflicts:
#	misc/table_driven_lsc.c
jjnicola added a commit that referenced this pull request Dec 16, 2021
…leanup (#997)

(cherry picked from commit 0e7d2f3)

# Conflicts:
#	misc/table_driven_lsc.c
jjnicola added a commit that referenced this pull request Dec 16, 2021
…leanup (#997) (#1002)

(cherry picked from commit 0e7d2f3)

# Conflicts:
#	misc/table_driven_lsc.c

Co-authored-by: Juan José Nicola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants