Fix: TLS support #1617
Merged
Fix: TLS support #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichtsfrei
previously approved these changes
Apr 9, 2024
Kraemii
requested changes
Apr 9, 2024
There was a problem hiding this comment.
Not sure about this fix, as the root cause why there are no client certs is not stated, even if it is clear, that either no path is configured, the given path is empty or the given path does not exist. Also not giving a client certs path could be wanted, when just TLS is sufficient
Fix: Improved the warnings and clarify why is running in TLS mode if client certs are not found. |
Kraemii
reviewed
Apr 11, 2024
jjnicola
force-pushed
the
tls
branch
2 times, most recently
from
7cbb19f
to
bfac28e
Compare
Kraemii
reviewed
Apr 11, 2024
Kraemii
previously approved these changes
Apr 12, 2024
nichtsfrei
reviewed
Apr 16, 2024
jjnicola
force-pushed
the
tls
branch
2 times, most recently
from
272d687
to
324f2a5
Compare
ArnoStiefvater
approved these changes
Apr 17, 2024
The server didn't start if the client certs were missing. With this fix, it is possible to start the server in TLS or mTLS modes
Kraemii
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix: TLS support
Why:
The server didn't start if the client certs were missing. With this fix, it is possible to start the server in TLS or mTLS modes
How:
Start openvasd without client cert options, without a valid directory or an empty directory.
Checklist: