Change: update hyper to version 1 #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichtsfrei
force-pushed
the
openvasd-hyper-hyper
branch
2 times, most recently
from
334d6eb
to
7ad11ce
Compare
jjnicola
previously approved these changes
Feb 1, 2024
This changes the underlying version of hyper to version 1. The run methods is moved to controller. This hypothetically allows us to run a complete server within tests. When TLS is enabled, which should be the case for all production environments, then it will use http2. On http it uses http1 so that it is more convenient to use with curl. The stream handling of results and oids is changed to channel and chunks as it is easier to understand and requires less code then our previous Stream approach. The handling of TLS and insecure mode are now more separated, although this results in wet code with a few duplication it is believed to be easier to change when there is a problem within one mode but not the other. The client identifier handling is also changed, rather then using wrapper upon wrapper we use a global arc in run and reset per request.
nichtsfrei
force-pushed
the
openvasd-hyper-hyper
branch
from
7ad11ce
to
b6028f3
Compare
Kraemii
reviewed
Feb 1, 2024
Kraemii
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the underlying version of hyper to version 1.
The run methods is moved to controller. This hypothetically allows us to
run a complete server within tests.
When TLS is enabled, which should be the case for all production
environments, then it will use http2. On http it uses http1 so that it
is more convenient to use with curl.
The stream handling of results and oids is changed to channel and chunks
as it is easier to understand and requires less code then our previous
Stream approach.
The handling of TLS and insecure mode are now more separated, although
this results in wet code with a few duplication it is believed to be
easier to change when there is a problem within one mode but not the
other.
The client identifier handling is also changed, rather then using
wrapper upon wrapper we use a global arc in run and reset per request.