Add: nasl-cli notus update subcommand #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load up Notus Advisories into redis. It performs the signature check, the hashsum check and the upload. Signature check is optional. It must be enabled with the command line option but also the environment variable to the gnupg keyring must be set. Usage: `GPGHOME=/path/to/.gnupg nasl-cli notus update --path <path-to-the-advisories> --signature-check`
jjnicola
force-pushed
the
advisories-loadup
branch
from
af55f35
to
7cb3e7b
Compare
nichtsfrei
reviewed
Jan 17, 2024
Since it is no not only for Nvts but also for Notus advisories.
|
thanks for the review @nichtsfrei |
|
I have been thinking about the separation between the 'notus' and 'feed' commands. Although it is technically correct to separate them, I'm questioning whether users actually need this differentiation or if they would rather 'verify' and 'update' them in one command? |
maybe something like |
instead of having two subcommands.
jjnicola
force-pushed
the
advisories-loadup
branch
from
d3e186b
to
4614a5c
Compare
nichtsfrei
approved these changes
Jan 24, 2024
ArnoStiefvater
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Load up Notus Advisories into redis.
It performs the signature check, the hashsum check and the upload.
Signature check is optional. It must be enabled with the command line option but also the environment variable to the gnupg keyring must be set.
Usage:
GPGHOME=/path/to/.gnupg nasl-cli notus update --path <path-to-the-advisories> --signature-checkJira: SC-997
Why:
How:
Checklist: