Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Smoketest for the scanner API #1480

Merged
merged 14 commits into from
Sep 11, 2023
Merged

Add: Smoketest for the scanner API #1480

merged 14 commits into from
Sep 11, 2023

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Aug 30, 2023 •
edited
Loading

What:
Add smoketest.
Currently, runs two test:

  • test 1: connection with the server (request HEAD)
  • test 2: run a scan (optionally with mtls activated)

Why:

How:

Checklist:

  • Tests
  • PR merge commit message adjusted

@jjnicola jjnicola force-pushed the smoketest branch 2 times, most recently from 81d4119 to 9c0b2f1 Compare August 31, 2023 05:37
@jjnicola jjnicola changed the title Smoketest Add: Smoketest for the scanner API Aug 31, 2023
@jjnicola jjnicola force-pushed the smoketest branch 2 times, most recently from 2f47824 to b370c59 Compare August 31, 2023 10:31
@jjnicola jjnicola marked this pull request as ready for review August 31, 2023 10:39
@jjnicola jjnicola requested a review from a team as a code owner August 31, 2023 10:39
@jjnicola jjnicola enabled auto-merge (squash) August 31, 2023 19:31
@jjnicola jjnicola requested a review from a team as a code owner September 7, 2023 09:44
@jjnicola jjnicola force-pushed the smoketest branch 2 times, most recently from 0a45414 to 3f80588 Compare September 7, 2023 10:02
nichtsfrei
nichtsfrei previously requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@nichtsfrei nichtsfrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unittests are failing

@jjnicola jjnicola force-pushed the smoketest branch 4 times, most recently from c2583d7 to 75e3cfb Compare September 8, 2023 10:28
@ArnoStiefvater ArnoStiefvater dismissed nichtsfrei’s stale review September 11, 2023 08:08

Blocks merge, we can handel the rest later

@jjnicola jjnicola merged commit 4640a51 into main Sep 11, 2023
28 checks passed
@jjnicola jjnicola deleted the smoketest branch September 11, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArnoStiefvater ArnoStiefvater ArnoStiefvater approved these changes

@nichtsfrei nichtsfrei Awaiting requested review from nichtsfrei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjnicola @nichtsfrei @ArnoStiefvater