Fix SecInfo alert filter conditions (master) #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alert_condition_description function did not get the expected count for the text.
This makes the $f and $F placeholders in the email body work.
The filter conditions previously counted all the NVTs for the "New/Updated SecInfo arrived" events, not just new or modified ones.
When checking if a filter count is met for SecInfo events, the SecInfo type given in the event data is counted instead of always counting NVTs.
When generating the lists of updated SecInfo for alerts all recently modified items are now added, no longer excluding new ones.
timopollmeier
changed the title
mattmundell
requested changes
Feb 11, 2020
In email_secinfo, quoted_filter_id needs to be freed and alert_secinfo_count contained a stray printf call.
…r/gvmd into secinfo-alert-filter-master
This reverts commit f9a8310 because omitting the existing items is the intended behavior.
timopollmeier
added
the
work in progress
The functions counting the SecInfo items for the filter condition and the ones generating the list for alert messages now all use the same conditions for the selection in the "Updated" case: The modification time must be newer than the feed time while the creation time must be older or the same.
timopollmeier
removed
the
work in progress
mattmundell
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various issues in the SecInfo filter conditions and makes them easier to use:
$fand$Ffor the email body are now replaced with the condition filterChecklist: