Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto sync predefined report formats from feed #970

Merged
merged 20 commits into from
Feb 8, 2020
Merged

Auto sync predefined report formats from feed #970

merged 20 commits into from
Feb 8, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Feb 4, 2020 •
edited by timopollmeier
Loading

Checklist:

@mattmundell
Remove current report format loading
35b6467
@mattmundell
Remove installation of predefined report formats
e3e1584
@mattmundell
Remove global flag from create_report_format
1387e07
@mattmundell
Add support for feed report formats
3c70637
@mattmundell
Add create_report_format_no_acl
4d65af3
@mattmundell
Sync feed report formats periodically
c6f4f1e
@mattmundell
Add report_format_updated_in_feed
f3100e0
@mattmundell
Add update_report_format
78d6357
@mattmundell
Move file storage out of create_report_format_internal
cf5afbf
@mattmundell
Check if report format exists when creating for feed
fc5dfee 
This is just an extra safety check.
@mattmundell
Replace files when updating feed report format
4f2f6ac
@mattmundell
Move param creation out of create_report_format_internal
a9c97f3
@mattmundell
Replace params when updating feed report format
0dc102b
@mattmundell
Fix doc
24d753d
@mattmundell
Use common function to free options
457a01d
@mattmundell
Activate feed report formats on creation
e08dd38
@mattmundell
Trust feed report formats on creation
8476c07
@mattmundell
Correct condition
1b861ac
@mattmundell
Mark feed report formats as predefined on creation
df93072 
This keeps the feed report formats consistent with the old report formats,
but prevents the owner from deleting them, so we're going to have to address
that.
@mattmundell
Update changelog
51ef35a
@mattmundell mattmundell marked this pull request as ready for review February 6, 2020 13:52
@mattmundell mattmundell merged commit d7300ef into greenbone:master Feb 8, 2020
@mattmundell mattmundell deleted the feed-report-formats branch February 8, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @timopollmeier