Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only set new_tag_return if copy_resource succeeds #953

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Only set new_tag_return if copy_resource succeeds #953

merged 1 commit into from
Jan 22, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Jan 22, 2020 •
edited
Loading

This is not a real issue because copy_tag's caller only uses new_tag_return on success. But the build checks picked up the error in #952, so fixing.

Checklist:

@mattmundell mattmundell marked this pull request as ready for review January 22, 2020 13:38
@mattmundell mattmundell mentioned this pull request Jan 22, 2020
Merged
2 tasks
@timopollmeier timopollmeier merged commit 25e85fa into greenbone:master Jan 22, 2020
@mattmundell mattmundell deleted the tag-init branch January 23, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @timopollmeier