Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rows of built-in default filters to -2 (9.0) #896

Merged
merged 4 commits into from
Dec 9, 2019

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Dec 9, 2019

If no filter or a filter without a rows keyword is given, the various
GET_... commands using filters will behave as if "rows=-2" was given
instead of "rows=-1".

This means they will only return the number of rows defined by the
"Rows Per Page" setting and the maximum amount of rows has to be
requested explicitly with a "rows=-1" filter keyword or
(where available) the ignore_pagination option.

Checklist:

If no filter or a filter without a rows keyword is given, the various
GET_... commands using filters will behave as if "rows=-2" was given
instead of "rows=-1".

This means they will only return the number of rows defined by the
"Rows Per Page" setting and the maximum amount of rows has to be
requested explicitly with a "rows=-1" filter keyword or
(where available) the ignore_pagination option.
@timopollmeier timopollmeier changed the title Change rows of built-in default filters to -2 Change rows of built-in default filters to -2 (9.0) Dec 9, 2019
@timopollmeier timopollmeier marked this pull request as ready for review December 9, 2019 15:34
mattmundell
mattmundell previously approved these changes Dec 9, 2019
@mattmundell mattmundell merged commit 30f7f02 into greenbone:gvmd-9.0 Dec 9, 2019
@timopollmeier timopollmeier deleted the get-default-rows-9.0 branch June 9, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants