Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creation of "Super" permissions (9.0) #892

Merged
merged 3 commits into from
Dec 4, 2019
Merged

Fix creation of "Super" permissions (9.0) #892

merged 3 commits into from
Dec 4, 2019

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Dec 4, 2019 •
edited
Loading

The permission name variable was freed too early so the comparison for
when to cache the permissions was not working as intended.

Checklist:

@timopollmeier
Fix creation of "Super" permissions
13bcfe6 
The permission name variable was freed too early so the comparison for
when to cache the permissions was not working as intended.
@timopollmeier timopollmeier changed the title Fix creation of "Super" permissions Fix creation of "Super" permissions (9.0) Dec 4, 2019
@timopollmeier timopollmeier marked this pull request as ready for review December 4, 2019 13:59
mattmundell
mattmundell requested changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be clearer if the strcasecmp that is using name used quoted_name, and the g_free of name remained where it is, because we're doing a second strcasecmp using quoted_name below.

@timopollmeier
Use quoted_name in create_permission_internal
10ceb89 
Revert the change from 13bcfe6 and
instead use the quoted_name, which is more consistent with a later
check if the permission is "Super".
@mattmundell mattmundell merged commit e32fc09 into greenbone:gvmd-9.0 Dec 4, 2019
@timopollmeier timopollmeier deleted the fix-super-permission-9.0 branch June 9, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmundell mattmundell mattmundell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timopollmeier @mattmundell