Extend command line options for managing scanners (master) #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option now also returns the type, host and port of each scanner.
This adds the scanner types "GMP" and "OSP-Sensor" to these options as well as the option to use the numeric type value used in GMP. Error messages when using the options are now always sent to stderr and are more specific about credential issues.
The new types and use of the numeric value are added to the --help output and man page.
This allows setting the credential of a scanner to an existing one or to unset the credential.
Instead of numbers the command will now return the types as strings as accepted by --create-scanner and --modify-sensor.
bjoernricks
suggested changes
Nov 14, 2019
|
@bjoernricks The name is already used internally and in the 9.0 branch, but it's not exposed to the user yet in the released version (9.0.0). |
|
@timopollmeier i really would like to use the term Greenbone-Sensor. IMHO OSP is only an implementation detail. |
|
But I am fine with changing this in another PR. |
bjoernricks
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #815, which extends the command line options
--get-scanners,--create-scannerand--modify-scannerto provide more information and accept more scanner types.Checklist: