Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 1.3.6.1.4.1.25623.1.0.90011 from Discovery config (9.0) #847

Merged
merged 3 commits into from
Nov 1, 2019

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Oct 30, 2019

The NVT is removed from the built-in "Discovery" config because it is
not available in every feed and only adds info already covered by other
NVTs.

Checklist:

The NVT is removed from the built-in "Discovery" config because it is
not available in every feed and only adds info already covered by other
NVTs.
@timopollmeier timopollmeier changed the title Remove 1.3.6.1.4.1.25623.1.0.90011 from Discovery config Remove 1.3.6.1.4.1.25623.1.0.90011 from Discovery config (9.0) Oct 30, 2019
The NVT 1.3.6.1.4.1.25623.1.0.90011 is now also removed from the
built-in Discovery config in existing databases.
@timopollmeier timopollmeier marked this pull request as ready for review November 1, 2019 07:49
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@@ -985,5 +985,12 @@ check_config_discovery (const char *uuid)
"yes",
TRUE);

sql ("DELETE FROM nvt_selectors"
" WHERE family_or_nvt = '1.3.6.1.4.1.25623.1.0.90011'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why github thinks the ' is a syntax error.

@mattmundell mattmundell merged commit bd4777a into greenbone:gvmd-9.0 Nov 1, 2019
@timopollmeier timopollmeier deleted the remove-smb-nvt-9.0 branch June 9, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants