Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add host_id filter for tls_certificates #835

Merged
merged 4 commits into from
Oct 30, 2019
Merged

Add host_id filter for tls_certificates #835

merged 4 commits into from
Oct 30, 2019

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Oct 25, 2019 •
edited
Loading

Checklist:

@timopollmeier timopollmeier marked this pull request as ready for review October 25, 2019 14:36
@timopollmeier
Fix condition for host_id tls_certificates filter
3c1ab3b 
The IP and the report id of the TLS certificate sources must match the
host identifiers simultaneously.
mattmundell
mattmundell requested changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the new filter term need to be added to the GMP docs?

@timopollmeier
Add new host_id filter option to GMP doc
abb8828 
The new keyword was missing in the get_tls_certificates documentation.
@timopollmeier
Copy link
Member Author

Does the new filter term need to be added to the GMP docs?

Thanks for reminding me. I've added it in abb8828.

@mattmundell mattmundell merged commit 6fe0511 into greenbone:gvmd-9.0 Oct 30, 2019
@timopollmeier timopollmeier deleted the tls-certificates-host-filter-9.0 branch June 9, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmundell mattmundell mattmundell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timopollmeier @mattmundell