Drop "modify_report" GMP command #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janowagner
added a commit
to janowagner/gsa
that referenced
this pull request
Oct 19, 2019
The command modify_report is being removed with greenbone/gvmd#823
janowagner
force-pushed
the
drop_modify_report_command
branch
from
42b1b03
to
7efb6cc
Compare
janowagner
requested review from
mattmundell and
timopollmeier
as code owners
mattmundell
requested changes
Oct 28, 2019
Also leave a note about this command being removed from the API.
It is not activated yet, as it is not invasive and could be done later.
janowagner
force-pushed
the
drop_modify_report_command
branch
from
dab919c
to
5138aa2
Compare
mattmundell
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command only offered to set a comment for a report. It was actually never
used by GSA.
Checklist: