Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round 5 of OTP cleanout #749

Merged
merged 21 commits into from
Sep 13, 2019
Merged

Round 5 of OTP cleanout #749

merged 21 commits into from
Sep 13, 2019

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Sep 11, 2019 •
edited
Loading

This should be the final round of cleanup. There's only one reference to
OTP left in the code: the name used by /etc/services for port 9390.

Checklist:

mattmundell and others added 21 commits September 11, 2019 16:38
@mattmundell
Remove comment about OTP update
9b71f10
@mattmundell
Change process name of GMP slave tasks
9a55224
@mattmundell
Correct doc
9114397
@mattmundell
Update comment that referred to otp.c
cec408d
@mattmundell
Remove unused SQL function 'tag'
36f8274
@mattmundell
Remove outdated suggestion from comment
6d24dda
@mattmundell
Correct comments about ports
5c831cc
@mattmundell
Merge branch 'master' into otp-cleanup-5
0065ea7
@mattmundell
Merge branch 'master' into otp-cleanup-5
6843fce
@mattmundell
Rename parse_otp_time to parse_utc_ctime
9c9f995
@mattmundell
Rename set_task_start_time_otp to set_task_start_time_ctime
cf5e639
@mattmundell
Rename set_scan_host_start_time_otp to set_scan_host_start_time_ctime
92885d9
@mattmundell
Rename set_scan_host_end_time_otp to set_scan_host_end_time_ctime
226def1
@mattmundell
Rename set_scan_end_time_otp to set_scan_end_time_ctime
c8f67ac
@mattmundell
Update arg docs to match rename
5586b9d
@mattmundell
Update doc references to OTP
9027c58
@mattmundell
Rename 'preference' iterator using 'config_preference'
b161a43
@mattmundell
Rename 'otp_preference' iterator using 'preference'
be4d6b1
@mattmundell
Remove serve_gmp timeout that is no longer used
0630d4c
@mattmundell
Remove unused OTP headers
1f574fb
@mattmundell
Make delete_task_lock static
6ea1e0f
@mattmundell mattmundell marked this pull request as ready for review September 12, 2019 09:45
timopollmeier
timopollmeier approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. There's only a minor question about an added comment where you mentioned "otp" even though you're trying to get rid of OTP.
If you think it's still correct or you'd rather address it later, I'm okay with merging this PR.

src/gvmd.c Show resolved Hide resolved
@timopollmeier timopollmeier merged commit 599944d into greenbone:master Sep 13, 2019
@mattmundell mattmundell deleted the otp-cleanup-5 branch September 30, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @timopollmeier