Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slave host asset handling (master) #736

Merged
merged 7 commits into from
Sep 4, 2019
Merged

Fix slave host asset handling (master) #736

merged 7 commits into from
Sep 4, 2019

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Sep 3, 2019 •
edited
Loading

This addresses the following issues:

  • Host assets may not be created if their first results are received at the end of the scan
  • The check if a host can be added to the assets may give unreliable results if the result_host does not exist

Checklist:

@timopollmeier
Create slave scan host assets after results
0f5b0aa 
The assets are created later in case the first results of a host are
received in the last update_from_slave call.
@timopollmeier
Initialize report_host in report_host_noticeable
4e0cf7f 
The unintialized value may point to an existing report host if actually
none exists otherwise, giving wrong results.
@timopollmeier
Merge branch 'master' into missing-host_noticeable
7ba5d65
@timopollmeier
Amend CHANGELOG for update_from_slave changes
1211fc5
@timopollmeier
Merge branch 'missing-host_noticeable' of github.com:timopollmeier/gv…
802b984 
…md into missing-host_noticeable
@timopollmeier
Merge branch 'master' into missing-host_noticeable
ee3feaf
@timopollmeier timopollmeier marked this pull request as ready for review September 4, 2019 08:37
@mattmundell mattmundell merged commit 651755b into greenbone:master Sep 4, 2019
@timopollmeier timopollmeier deleted the missing-host_noticeable branch June 9, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmundell mattmundell mattmundell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timopollmeier @mattmundell