Make --osp-vt-update optional, use default scanner #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OSP VT update socket no longer has to be given with the command line if the socket path of the "OpenVAS Default" scanner can be used instead. Also, update_nvt_cache_retry will no longer fork endlessly if the socket path is still NULL for some reason.
mattmundell
requested changes
Sep 1, 2019
If the update fails because of a missing socket the forked process will now exit with this more standard status code.
mattmundell
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OSP VT update socket no longer has to be given with the command line
if the socket path of the "OpenVAS Default" scanner can be used instead.
Also, update_nvt_cache_retry will no longer fork endlessly if the socket
path is still NULL for some reason and the documentation is updated.
Checklist: