Use explicit nvti timestamps #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the seconds since epoche in the nvti structure.
Now that the timestamps are explicitly stored in the nvti as seconds since epoch, use them directly and don't parse the out of the tags sttring anymore.
Since we store the timestamps now directly and also use the directly, we do need to append them to the tags string anymore.
Since the timestamps do not appear anymore in the tags string, there is no need to parse them out of the tags string. Now the tags string can simply directly be inserted into the database as is.
janowagner
force-pushed
the
resolve_tags
branch
from
efad960
to
578cdd5
Compare
janowagner
requested review from
mattmundell and
timopollmeier
as code owners
mattmundell
approved these changes
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When arriving via OSP, immediately parse timestamps into seconds since epoch.
Checklist: