Make several NVTI tags internally explicit. #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmundell
requested changes
Aug 26, 2019
mattmundell
reviewed
Aug 26, 2019
janowagner
force-pushed
the
resolve_tags
branch
from
20815b4
to
27b3d75
Compare
These new iterstors are for the new explciit nvt elements "summary", "insight", "affected", "impact" and "detection". These are implemented analog to the existing ones.
Since these elements do not appear anymore in the internal tag string they need to be appended in order to keep API compatibility.
For compatibility add the now-expclicit elements to the tag string.
The new elements need to be added for the case when the table "nvts" is created anew.
Internally in the data model in table nvts several elements are now handled explicitely instead of being stored in the "tag" string. When reading them from OSP (where they are already explciit elements) they are not anymore serialized into the tag string. They are rather directly stored into the extended nvti structure. While doing so also a bug is fixed because "impact" was missing when parsing OSP VT information.
janowagner
force-pushed
the
resolve_tags
branch
from
27b3d75
to
05d9e75
Compare
mattmundell
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the elements "summary", "insight", "detection", "impact" and "affected" explicit columns of the table "nvts".
These elements are already explicit in the vt object incoming via OSP.
For keeping GMP API compatibility, the 5 elements are serialized into the "tag" string.
The API is not modified, the changes are only internally.
This PR requires greenbone/gvm-libs#258
Checklist: