Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RAW_DATA of GET_INFO for type NVT #682

Merged
merged 4 commits into from
Aug 12, 2019
Merged

Fix RAW_DATA of GET_INFO for type NVT #682

merged 4 commits into from
Aug 12, 2019

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Aug 10, 2019 •
edited by timopollmeier
Loading

Checklist:

@mattmundell
Quote OID in find_nvt
2e2c4e2
@mattmundell
Prefer uid over name for NVTs in manage_read_info
cb38b34 
This gets RAW_DATA working for GET_INFO when type is 'nvt'.
handle_get_info is calling manage_read_info with both name and uid to
fill the RAW_DATA, so it got no data because manage_read_info was trying
to find the NVT using the NVT name.

There's no change in behaviour of GET_INFO when given an NVT as name or
info_id, because it is forbidden to give both.
@mattmundell
Add changelog entry
76848e6
@mattmundell mattmundell marked this pull request as ready for review August 10, 2019 15:11
@mattmundell mattmundell changed the title Quote sql Fix RAW_DATA of GET_INFO for type NVT Aug 10, 2019
@timopollmeier timopollmeier merged commit a7ff9ac into greenbone:master Aug 12, 2019
@mattmundell mattmundell deleted the quote-sql branch August 12, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @timopollmeier