Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve tags: solution and solution_type #681

Merged
merged 8 commits into from
Aug 11, 2019

Commits on Aug 10, 2019

  1. Handle solution and solutuion_type explicite in db

    This prepares to have both not anymore in the pipe-separated tag list.
    However, this patch makes the solution appear twice in the nvts table
    for the time being. Just like solution_type already.
    
    This patch expects that there is a additional column in the nvt
    table "solution." A migrator is forthcoming, for testing this can
    be done:
    ALTER TABLE IF EXISTS nvts ADD COLUMN solution text;
    janowagner committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    55f8abd View commit details
    Browse the repository at this point in the history
  2. Add migrator for extending nvt with previous tags.

    This one adds the solution.
    janowagner committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    00156a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2019

  1. Add result iterator for nvt solution,solution_type

    This allows to access solution and solution_type when
    iterating over results.
    janowagner committed Aug 11, 2019
    Configuration menu
    Copy the full SHA
    23f80d6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    21ba0e9 View commit details
    Browse the repository at this point in the history
  3. get_nvts: Append solution/solution_type to tag

    This also serves get_info for type NVT.
    The explicit elements "solution" and "solution_type" are appended
    to the pipe-separated tag element of the nvt.
    This is a temporary solution until the XML structure of a NVT
    has explicit solution and solution_type elements. Once
    that is established, we don't need to append them to the tags anymore.
    janowagner committed Aug 11, 2019
    Configuration menu
    Copy the full SHA
    2ea97b7 View commit details
    Browse the repository at this point in the history
  4. Append solution(_type) to nvt of get_results

    This appends the explicit stored solution and solutions_type
    to the pipe-separated tag element. Once the solution and
    solution_type are explicit elements of the XML definition,
    this can be dropped.
    janowagner committed Aug 11, 2019
    Configuration menu
    Copy the full SHA
    ba5fc61 View commit details
    Browse the repository at this point in the history
  5. Don't add special tags anymore into database.

    Since solution and solution_type are now appended
    to the tag string for API compaitibility where the respective XML
    is created, we do not need to store them into the tag in the database
    anymmore!
    janowagner committed Aug 11, 2019
    Configuration menu
    Copy the full SHA
    4ac7224 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    08cd580 View commit details
    Browse the repository at this point in the history