Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use read instead of xargs for sendmail (master) #678

Merged
merged 3 commits into from
Aug 9, 2019
Merged

Use read instead of xargs for sendmail (master) #678

merged 3 commits into from
Aug 9, 2019

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Aug 9, 2019 •
edited
Loading

This separates the arguments instead of sending them as one.

Checklist:

@timopollmeier
Use read instead of xargs for sendmail
f6e8749 
This separates the arguments instead of sending them as one.
@timopollmeier timopollmeier marked this pull request as ready for review August 9, 2019 14:53
mattmundell
mattmundell approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ssmtp says

-fname Sets the name of the ``from'' person. This option is valid only if no From: line is specified within the header of the email.

so using -f may cause problems because we still include "From:". Not sure about other mail agents.

@mattmundell mattmundell merged commit 8bfa109 into greenbone:master Aug 9, 2019
@timopollmeier timopollmeier deleted the sendmail-args branch June 9, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmundell mattmundell mattmundell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timopollmeier @mattmundell