Drop table nvt_cves #574
Merged
Drop table nvt_cves #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmundell
requested changes
May 30, 2019
For building the relationship between dfn-cert and cert-bund to nvts via CVE's, the special table nvt_cves was used. Now that we have vt_refs that includes the information needed from nvt_cves, use vt_refs directly. This is one step towards removing the redundant table nvt_cves.
This removes the function refresh_nvt_cves() and any call of it. Since refeshed table isn't used anymore, the refreshing does not need to be done as well.
Since we do not need this table anymore, do not even create it at start time. Also do not create an index for it.
janowagner
force-pushed
the
drop_table_nvt_cves
branch
from
81e3e3c
to
b6fdd16
Compare
The new vt_refs table should be pretty fast as well. But yes, we keep an eye on it.
Done |
mattmundell
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming we have the new table vt_refs as proposed in
#570
we do not need the table "nvt_cves" anymore.
This PR removes the table and takes care vt_refs is used to achieve the same.
Therefore the above cited PR is mandatory before applying this PR. No conflict for compile time, but at run-time it would fail with SQL errors.
The PR does not include a migrator to remove existing tables. This should be subject to another
PR.