Adjust to use new API for vt references. #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janowagner
added
the
work in progress
janowagner
removed
the
work in progress
timopollmeier
previously approved these changes
May 14, 2019
mattmundell
requested changes
May 14, 2019
Use the new API for VT references and thus simplify the creation of XML to just a few lines of code.
The functions result_iterator_nvt_cve() and result_iterator_nvt_xref() are in fact not used anywhere an thus can be removed. This resolves the open todo's as well.
This prevents that one of the "NO*" keywords end up in the table "nvts".
Since the term "NOCVE" does not exist anymore, we need to chec for an empty field rather this special keyword.
mattmundell
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes correspond to greenbone/gvm-libs#225
where the C API is change to have unified cross references.