Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: functions to handle an Openvasd scan task #2262

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Jul 17, 2024

What

Add: functions to handle an Openvasd scan task
SC-1056
SC-1053
SC-1058
SC-1057
SC-1060

Why

Required for handling scans via openvasd

References

Checklist

  • Tests

Copy link

github-actions bot commented Jul 17, 2024

Conventional Commits Report

Type Number
Added 3

🚀 Conventional commits found.

@jjnicola
Copy link
Member Author

jjnicola commented Jul 17, 2024

Depends on greenbone/gvm-libs#826

@jjnicola
Copy link
Member Author

Depends on #2169

@jjnicola jjnicola force-pushed the openvasd-integration branch 2 times, most recently from a19d368 to d5d1f2a Compare September 27, 2024 11:34
@jjnicola jjnicola force-pushed the openvasd-integration branch 4 times, most recently from ff7a256 to 0e31fee Compare October 14, 2024 17:35
@@ -2571,8 +3166,27 @@ manage_sync_nvts (int (*fork_update_nvt_cache) (pid_t*))
int
update_or_rebuild_nvts (int update)
{
gchar *db_feed_version, *scanner_feed_version;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gchar *db_feed_version, *scanner_feed_version;
gchar *db_feed_version, *scanner_feed_version;

@@ -20074,14 +20079,17 @@ nvt_severity (const char *nvt_id, const char *type)
{
char *severity = NULL;

if (strcasecmp (type, "Alarm") == 0 && nvt_id)
if ((strcasecmp (type, "alarm") == 0 || strcasecmp (type, "Alarm") == 0) && nvt_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just browsing through and this looks weird, because strcasecmp ignores case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants