Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle get_license and modify_license permission #1696

Merged
merged 4 commits into from
Oct 13, 2021

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Oct 11, 2021

What:
The two permissions for the license are now valid to use in
create_permission and modify_permission.

Why:
So the license commands can be used as expected from other GMP commands.
(Fixes AP-1670)

How did you test it:

  • By getting the license with a user with role "User" that has the explicit "get_license" permission, not "everything".
  • By creating a "get_license" using the create_permission GMP command.

Checklist:

@timopollmeier timopollmeier marked this pull request as ready for review October 12, 2021 07:18
@timopollmeier timopollmeier requested a review from a team as a code owner October 12, 2021 07:18
@timopollmeier timopollmeier merged commit 4088f58 into greenbone:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants