Log warning if --rebuild-gvmd-data fails #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to printing it to stdout the failure message will also be written to the gvmd log.
jhelmold
approved these changes
Sep 8, 2021
timopollmeier
added a commit
that referenced
this pull request
Sep 8, 2021
Log warning if --rebuild-gvmd-data fails (backport #1683)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
In addition to printing it to stdout the failure message will also
be written to the gvmd log.
Why:
Having a warning in the log helps finding the reason for a failure
if the rebuild is automated.
How did you test it:
By making the rebuild fail due to a concurrent
gvmd --rebuild.Checklist: