Handle empty --vt-verification-collation correctly #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option will now automatically select the verification if an empty string is given, not just if the option is missing completely.
timopollmeier
added
backport-to-oldstable
Omitting the option is now also mentioned.
bjoernricks
approved these changes
Jul 29, 2021
This was referenced Jul 29, 2021
timopollmeier
added a commit
that referenced
this pull request
Jul 29, 2021
Handle empty --vt-verification-collation correctly (backport #1651)
timopollmeier
added a commit
that referenced
this pull request
Jul 29, 2021
Handle empty --vt-verification-collation correctly (backport #1651)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The option will now automatically select the verification if an empty
string is given, not just if the option is missing completely.
Why:
The behavior for the option missing and having an empty value should
be consistent (AP-1609).
How did you test it:
By running
gvmd --vt-verification-collation ""Checklist: