Add trash columns for target "elevate" credential #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The columns for the SSH elevate credential were missing for targets in the trashcan (TARGET_ITERATOR_TRASH_COLUMNS), so getting targets in the trashcan did not work correctly.
bjoernricks
approved these changes
Jul 22, 2021
jhelmold
approved these changes
Jul 22, 2021
|
The changes look good to me. |
bjoernricks
added a commit
that referenced
this pull request
Jul 23, 2021
Add trash columns for target "elevate" credential (backport #1636)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This adds the columns for the SSH elevate credential and its location
to TARGET_ITERATOR_TRASH_COLUMNS
Why:
The columns for the SSH elevate credential were missing for targets in
the trashcan, so getting targets in the trashcan did not work correctly.
Without the fix the shown credentials may be wrong or getting the targets
in the trash may not work at all.
(Fixes AP-1554)
How did you test it:
By creating targets with different SSH elevate credentials, then moving
them and some of the credentials to the trashcan.
When checking the the trashcan page, they should appear with the correct
credentials in particular.
Checklist: