Added retry of sensor connection for performance reports on failure. (backport #1633) #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
In manage.c in function get_osp_performance_string (..): The installation of the connection to the sensor via osp_connect_with_data (..) and the access to the performance data via osp_get_performance_ext (..) are now retried several times on failure. (cherry picked from commit ede0f95)
(cherry picked from commit e4f77af)
in manage.c, in function get_osp_performance_string(..): Moved the declaration of the variable "return_value" to the top of the function. (cherry picked from commit 50ee82b)
In manage.c, in function get_osp_performance_string (..): Replaced the assignment of value "connection_retry = SCANNER_CONNECTION_RETRY_DEFAULT;" by "connection_retry = get_scanner_connection_retry();". (cherry picked from commit 3fa7218)
In manage.c in function get_osp_performance_string (..): Amended the formatting of a while statement and the calls of get_scanner_connection_retry (). (cherry picked from commit 2d13c54)
In manage.c, in function get_osp_performance_string (..): Rebuild the logic of the connection retries for osp_connect_with_data (..) and osp_get_performance_ext (..) slightly. (cherry picked from commit 0d06084)
timopollmeier
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1633 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/