Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation and collation of vts_verification_str #1629

Merged

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Jul 9, 2021

What:
When creating SQL functions, it is first checked if the tables "nvts" and
"nvt_preferences" exist before trying to create vts_verification_str.
The function now also uses the collation "ucs_basic", which should be
available by default.

Why:
This addresses #1608 and an issue with new installations reported at https://community.greenbone.net/t/postgresql-error-when-running-latest-version-update-of-gvm-21-04/9625

How did you test it:

Checklist:

When creating SQL functions, it is first checked if the tables "nvts" and
"nvt_preferences" exist before trying to create vts_verification_str.
The function now also uses the collation "ucs_basic", which should be
available by default.
@timopollmeier timopollmeier added backport-to-oldstable This pull request will be backported to the oldstable branch backport-to-21.04 labels Jul 9, 2021
@timopollmeier timopollmeier marked this pull request as ready for review July 9, 2021 12:53
@timopollmeier timopollmeier requested a review from a team as a code owner July 9, 2021 12:53
@bjoernricks bjoernricks merged commit 979616b into greenbone:master Jul 9, 2021
bjoernricks added a commit that referenced this pull request Jul 9, 2021
Fix creation and collation of vts_verification_str (backport #1629)
bjoernricks added a commit that referenced this pull request Jul 9, 2021
Fix creation and collation of vts_verification_str (backport #1629)
@timopollmeier timopollmeier deleted the fix-vts_verification_str branch October 15, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-oldstable This pull request will be backported to the oldstable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants