Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to install PostgreSQL extensions automatically #1483

Merged
merged 5 commits into from
Apr 13, 2021

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Apr 12, 2021

What:
The check_db_extensions function will now check if the required
extensions are available to be installed and try to install them
with the database superuser role.

Why:
To make the

How did you test it:
By removing the "uuid-ossp" extension with the SQL DROP EXTENSION "uuid-ossp";, then running gvmd and checking that the extension is automatically installed again with SELECT * FROM pg_extension;.

Checklist:

The check_db_extensions function will now check if the required
extensions are available to be installed and try to install them
with the database superuser role.
The manage_create_sql_functions function now uses check_db_extensions to
ensure all required extensions are installed.
To ensure the superuser role name ("dba") is used consistently, it is
now defined as the macro DB_SUPERUSER_ROLE.
This point of the installation is now obsolete as the extensions are
installed by gvmd.
@timopollmeier timopollmeier marked this pull request as ready for review April 12, 2021 13:16
@timopollmeier timopollmeier requested a review from a team as a code owner April 12, 2021 13:16
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@bjoernricks bjoernricks merged commit be53adf into greenbone:gvmd-20.08 Apr 13, 2021
@timopollmeier timopollmeier added backport-to-21.04 backport-to-main This pull request will be ported to the master branch labels Apr 28, 2021
timopollmeier added a commit that referenced this pull request Apr 29, 2021
Try to install PostgreSQL extensions automatically (backport #1483)
timopollmeier added a commit that referenced this pull request Apr 29, 2021
This addresses two conflicts:
* The numbering of the instructions in INSTALL.md had to be adjusted for
 the new pg-gvm installation step.
* The check_db_extensions function now includes the check for and the
 creation of the pg-gvm extension.
timopollmeier added a commit that referenced this pull request Apr 29, 2021
Try to install PostgreSQL extensions automatically (backport #1483)
@timopollmeier timopollmeier deleted the add-extensions branch October 15, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-main This pull request will be ported to the master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants