-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to install PostgreSQL extensions automatically #1483
Merged
bjoernricks
merged 5 commits into
greenbone:gvmd-20.08
from
timopollmeier:add-extensions
Apr 13, 2021
Merged
Try to install PostgreSQL extensions automatically #1483
bjoernricks
merged 5 commits into
greenbone:gvmd-20.08
from
timopollmeier:add-extensions
Apr 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check_db_extensions function will now check if the required extensions are available to be installed and try to install them with the database superuser role.
The manage_create_sql_functions function now uses check_db_extensions to ensure all required extensions are installed.
To ensure the superuser role name ("dba") is used consistently, it is now defined as the macro DB_SUPERUSER_ROLE.
This point of the installation is now obsolete as the extensions are installed by gvmd.
bjoernricks
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
timopollmeier
added
backport-to-21.04
backport-to-main
This pull request will be ported to the master branch
labels
Apr 28, 2021
This was referenced Apr 28, 2021
timopollmeier
added a commit
that referenced
this pull request
Apr 29, 2021
Try to install PostgreSQL extensions automatically (backport #1483)
timopollmeier
added a commit
that referenced
this pull request
Apr 29, 2021
This addresses two conflicts: * The numbering of the instructions in INSTALL.md had to be adjusted for the new pg-gvm installation step. * The check_db_extensions function now includes the check for and the creation of the pg-gvm extension.
timopollmeier
added a commit
that referenced
this pull request
Apr 29, 2021
Try to install PostgreSQL extensions automatically (backport #1483)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The check_db_extensions function will now check if the required
extensions are available to be installed and try to install them
with the database superuser role.
Why:
To make the
How did you test it:
By removing the "uuid-ossp" extension with the SQL
DROP EXTENSION "uuid-ossp";
, then running gvmd and checking that the extension is automatically installed again withSELECT * FROM pg_extension;
.Checklist: