Improve modify_override errors, fix no NVT case #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command will now return relevant syntax errors if the threat or severity elements are invalid or required ones are missing. Also, the case where no NVT OID is given has been fixed.
timopollmeier
added
backport-to-21.04
backport-to-main
|
@Mergifyio refresh |
|
Command
|
timopollmeier
added a commit
that referenced
this pull request
Mar 8, 2021
The conflict in the modify_override improvement was due to the "Debug" severity level being removed.
bjoernricks
added a commit
that referenced
this pull request
Mar 8, 2021
Improve modify_override errors, fix no NVT case (bp #1435)
timopollmeier
added a commit
that referenced
this pull request
Mar 8, 2021
The conflict in the modify_override improvement was due to the "Debug" severity level being removed.
bjoernricks
added a commit
that referenced
this pull request
Mar 8, 2021
Improve modify_override errors, fix no NVT case (bp #1435)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The command will now return relevant syntax errors if the threat or
severity elements are invalid or required ones are missing.
Also, the case where no NVT OID is given has been fixed.
Why:
The improved error messages help clarify to users what kind of input
is expected and the NVT case make the behavior consistent with the
GMP specification.
How did you test it:
By running the command via gvm-pyshell.
Checklist: