Add standard info elem fields for NVTs in get_info #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard elements and attributes like id, name, modification_time etc. are also included in the info element for NVTs for consistency with other get_info types and the GMP documentation. This also simplifies the handling of NVTs a bit.
timopollmeier
added
backport-to-21.04
backport-to-main
bjoernricks
approved these changes
Feb 25, 2021
timopollmeier
added a commit
that referenced
this pull request
Feb 25, 2021
Add standard info elem fields for NVTs in get_info (bp #1426)
|
@Mergifyio refresh |
|
Command
|
timopollmeier
added a commit
that referenced
this pull request
Feb 25, 2021
Add standard info elem fields for NVTs in get_info (bp #1426)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
With this change, the standard elements and attributes like
id, name, modification_time etc. are also included in the info element for NVTs.
Why:
for consistency with
other get_info types and the GMP documentation.
This also simplifies the handling of NVTs a bit.
How did you test it:
Tested by getting a single NVT via
gvm-cliand comparing the responses.Checklist: