Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "Failed to find..." messages (20.08) (bp #1395) #1413

Merged
merged 5 commits into from
Feb 8, 2021
Merged

Improve "Failed to find..." messages (20.08) (bp #1395) #1413

merged 5 commits into from
Feb 8, 2021

Commits on Feb 8, 2021

  1. Improve get_info "Failed to find..." message 

    If a SecInfo entry cannot be found by ID or name, the error message will
say it cannot find the given ID or name instead of a misleading message
that the type could not be found.

(cherry picked from commit fc01f50)
    @timopollmeier
    timopollmeier authored and mergify-bot committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    66635e5 View commit details
    Browse the repository at this point in the history

  2. Add improved get_info error message to CHANGELOG 

    (cherry picked from commit b34580e)
    @timopollmeier
    timopollmeier authored and mergify-bot committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    baee3d6 View commit details
    Browse the repository at this point in the history

  3. Use XML-escaping in send_find_error_to_client 

    This ensures the error messages work if reserved characters are used in
the requested id or name.

(cherry picked from commit 9504567)
    @timopollmeier
    timopollmeier authored and mergify-bot committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    527d804 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG for "Failed to find" messages 

    (cherry picked from commit 50adcc9)
    @timopollmeier
    timopollmeier authored and mergify-bot committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    09ae272 View commit details
    Browse the repository at this point in the history

  5. Fix filt_id "Failed to find filter" messages 

    Some of the messages used the type of the get_... command instead of
"filter" when the filter given by filt_id could not be found.

(cherry picked from commit d522fec)
    @timopollmeier
    timopollmeier authored and mergify-bot committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    08758be View commit details
    Browse the repository at this point in the history