add <detection></detection> on report import #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing a report with <detection> and even if it has the correct nvt as a host_detail as well as an result within the report the detection block was missing when importing via create_report. To add those sections two new entries within host_details will be added when a <detection> got found within a result.
y0urself
reviewed
Feb 3, 2021
Co-authored-by: Jaspar L. <[email protected]>
if else if formatting.
timopollmeier
requested changes
Feb 3, 2021
Co-authored-by: Timo Pollmeier <[email protected]>
To have more fine grnaular control over the found detections the location should be included into detected_by.
This reverts commit 9ee207e.
you're right changed it to use |
timopollmeier
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
When importing a report with and even if it has the correct
nvt as a host_detail as well as an result within the report the
detection block was missing when importing via create_report.
To add those sections two new entries within host_details will be added
when a got found within a result.
Why:
How did you test it:
To test it you need to have a report with
in it, the source_oid of those detection must be also available as result nvt oid entry.
With that given you need to import that report into an container task and then download the report via gsa.
Checklist: