Improve "Failed to find..." messages (20.08) #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a SecInfo entry cannot be found by ID or name, the error message will say it cannot find the given ID or name instead of a misleading message that the type could not be found.
mattmundell
requested changes
Jan 20, 2021
| get_info_data->type, | ||
| if (send_find_error_to_client ("get_info", | ||
| get_info_data->name | ||
| ? "name" |
There was a problem hiding this comment.
I think this would break if name/id contained a ".
It was safe for type because it's checked above.
There was a problem hiding this comment.
I think this is a general issue with send_find_error_to_client that was only avoided so far because of the id validation in GSA, so I'll change that function to XML escape the input.
There was a problem hiding this comment.
The issue should be addressed with 9504567.
This ensures the error messages work if reserved characters are used in the requested id or name.
timopollmeier
changed the title
Some of the messages used the type of the get_... command instead of "filter" when the filter given by filt_id could not be found.
mattmundell
approved these changes
Jan 21, 2021
timopollmeier
added
the
backport-to-main
timopollmeier
added a commit
that referenced
this pull request
Feb 8, 2021
Improve "Failed to find..." messages (20.08) (bp #1395)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This fixes the following issues with the "Failed to find..." messages.
say it cannot find the given ID or name instead of a message that the
type could not be found.
filt_idcannot be found now say "filter"instead of using the type of the
get_command.Why:
an invalid
info_typewas used.reserved characters, the response would be invalid.
How did you test it:
Checklist: