Replace g_file_test with gvm-libs file tests (20.08) #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new functions use the effective UID/GID when checking if a file is accessible so gvmd can be used with the file flags to set UID and GID.
timopollmeier
force-pushed
the
file-tests-20.08
branch
from
4d41af9
to
fa79901
Compare
mattmundell
previously approved these changes
Jan 19, 2021
| @@ -9297,7 +9297,7 @@ alert_script_exec (const char *alert_id, const char *command_args, | |||
|
|
|||
| script = g_build_filename (script_dir, "alert", NULL); | |||
|
|
|||
| if (!g_file_test (script, G_FILE_TEST_EXISTS)) | |||
| if (! gvm_file_is_readable (script)) | |||
There was a problem hiding this comment.
Not sure about the space, everywhere else uses !call.
There was a problem hiding this comment.
Changed this in 2ffceab.
mattmundell
approved these changes
Jan 20, 2021
timopollmeier
added
the
backport-to-main
timopollmeier
added a commit
that referenced
this pull request
Feb 8, 2021
Replace g_file_test with gvm-libs file tests (20.08) (bp #1391)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This replaces the
g_file_testcalls with the functions gvm_file_existsgvm_file_is_executable and gvm_file_is_readable, which were added
in greenbone/gvm-libs#422.
Why:
The new functions use the effective UID/GID when checking if a file is
accessible so gvmd can be used with the file flags to set UID and GID.
How did you test it:
--relay-mapperoption withChecklist: