Expect report format scripts to exit with code 0 #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To detect more errors, run_report_format_script will handle any non-zero exit code from the generate script as a failure.
mattmundell
requested changes
Dec 21, 2020
src/manage_sql_report_formats.c
Outdated
| * specified what it must be in the past. */ | ||
| if (ret == -1) | ||
| /* Report scripts should return 0 since version 21.04 */ | ||
| if (ret) |
There was a problem hiding this comment.
The return from system is either -1 or a "wait status". Should you be checking for -1 and using WEXITSTATUS?
There was a problem hiding this comment.
I've changed this in e96859a
Instead of relying on `system` to always return 0 on success, the return code is checked with WIFEXITED if the script terminated normally and WEXITSTATUS is used to check the exit status.
mattmundell
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
To detect more errors, run_report_format_script will handle any non-zero
exit code from the generate script as a failure.
Why:
Being stricter about the return codes makes it easier to detect if errors occur running the report format scripts.
How did you test it:
I modified a report format
generatescript to return a non-zero exit code and loaded a report in GSA using it.Checklist: