Fix response memory handling in handle_osp_scan #1364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
When getting only the progress, the XML string is no longer requested
and when getting the full report, the string is freed in case of an
error.
Why:
The XML from the progress requests was never freed until the end of the scan,
so the strings kept consuming more and more memory, which could cause
problems during longer scans.
How did you test it:
By observing the memory consumption of the scan handler process in
htop
andprofiling gvmd with the massif tool of Valgrind while scanning a large range of
alive hosts.
Checklist: