Add check if gvmd data feed dir exists

CHANGELOG.md

@@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Add command line options db-host and db-port [#1308](https://github.com/greenbone/gvmd/pull/1308)
 - Add missing config and target to modify_task GMP doc [#1310](https://github.com/greenbone/gvmd/pull/1310)
 - Add version for NVTs and CVEs in make_osp_result [#1335](https://github.com/greenbone/gvmd/pull/1335)
+- Add check if gvmd data feed dir exists [#1360](https://github.com/greenbone/gvmd/pull/1360)
 
 ### Changed
 - Extended the output of invalid / missing --feed parameter given to greenbone-feed-sync [#1255](https://github.com/greenbone/gvmd/pull/1255)

src/gvmd.c

@@ -1212,6 +1212,9 @@ fork_feed_sync ()
 {
   int pid;
   sigset_t sigmask_all, sigmask_current;
+  gboolean gvmd_data_feed_dir_exists;
+
+  static gboolean disable_gvmd_data_feed_warning = FALSE;
 
   if (feed_version_check_in_progress)
     {
@@ -1235,6 +1238,22 @@ fork_feed_sync ()
       return -1;
     }
 
+  gvmd_data_feed_dir_exists = manage_gvmd_data_feed_dir_exists ();
+
+  if (disable_gvmd_data_feed_warning && gvmd_data_feed_dir_exists)
+    {
+      disable_gvmd_data_feed_warning = FALSE;
+      g_message ("Previously missing gvmd data feed directory %s found.",
+                 GVMD_FEED_DIR);
+    }
+  else if (gvmd_data_feed_dir_exists == FALSE
+           && disable_gvmd_data_feed_warning == FALSE)
+    {
+      disable_gvmd_data_feed_warning = TRUE;
+      g_warning ("The gvmd data feed directory %s does not exist.",
+                 GVMD_FEED_DIR);
+    }
+
   pid = fork_with_handlers ();
   switch (pid)
     {
@@ -1256,7 +1275,8 @@ fork_feed_sync ()
 
         /* Check the feed version. */
 
-        manage_sync (sigmask_normal, fork_update_nvt_cache);
+        manage_sync (sigmask_normal, fork_update_nvt_cache,
+                     gvmd_data_feed_dir_exists);
 
         /* Exit. */
 

src/manage.c

@@ -7330,6 +7330,8 @@ feed_sync_required ()
   return FALSE;
 }
 
+
+
 /**
  * @brief Perform any syncing that is due.
  *
@@ -7338,10 +7340,12 @@ feed_sync_required ()
  * @param[in]  sigmask_current  Sigmask to restore in child.
  * @param[in]  fork_update_nvt_cache  Function that forks a child that syncs
  *                                    the NVTS.  Child does not return.
+ * @param[in]  try_gvmd_data_sync  Whether to try to sync gvmd data objects.
  */
 void
 manage_sync (sigset_t *sigmask_current,
-             int (*fork_update_nvt_cache) ())
+             int (*fork_update_nvt_cache) (),
+             gboolean try_gvmd_data_sync)
 {
   lockfile_t lockfile;
 
@@ -7360,9 +7364,12 @@ manage_sync (sigset_t *sigmask_current,
         }
     }
 
-  manage_sync_configs ();
-  manage_sync_port_lists ();
-  manage_sync_report_formats ();
+  if (try_gvmd_data_sync)
+    {
+      manage_sync_configs ();
+      manage_sync_port_lists ();
+      manage_sync_report_formats ();
+    }
 }
 
 /**
@@ -8408,6 +8415,17 @@ sort_data_free (sort_data_t *sort_data)
 
 /* Feeds. */
 
+/**
+ * @brief Tests if the gvmd data feed directory exists.
+ *
+ * @return TRUE if the directory exists.
+ */
+gboolean
+manage_gvmd_data_feed_dir_exists ()
+{
+  return g_file_test (GVMD_FEED_DIR, G_FILE_TEST_EXISTS);
+}
+
 /**
  * @brief Get the feed lock file path.
  *

src/manage.h

@@ -2673,7 +2673,7 @@ void
 set_scheduled_user_uuid (const gchar* uuid);
 
 void
-manage_sync (sigset_t *, int (*fork_update_nvt_cache) ());
+manage_sync (sigset_t *, int (*fork_update_nvt_cache) (), gboolean);
 
 int
 manage_schedule (manage_connection_forker_t,
@@ -3657,6 +3657,9 @@ aggregate_iterator_subgroup_value (iterator_t*);
 #define CERT_FEED 3
 #define GVMD_DATA_FEED 4
 
+gboolean
+manage_gvmd_data_feed_dir_exists ();
+
 const gchar *
 get_feed_lock_path ();
 

src/manage_configs.c

@@ -379,6 +379,11 @@ sync_configs_with_feed ()
   const gchar *config_path;
   gchar *nvt_feed_version;
 
+  /* Test if base feed directory exists */
+
+  if (manage_gvmd_data_feed_dir_exists () == FALSE)
+    return 0;
+
   /* Only sync if NVTs are up to date. */
 
   nvt_feed_version = nvts_feed_version ();

src/manage_port_lists.c

@@ -312,6 +312,11 @@ sync_port_lists_with_feed ()
   GDir *dir;
   const gchar *port_list_path;
 
+  /* Test if base feed directory exists */
+
+  if (manage_gvmd_data_feed_dir_exists () == FALSE)
+    return 0;
+
   /* Setup owner. */
 
   setting_value (SETTING_UUID_FEED_IMPORT_OWNER, &current_credentials.uuid);

src/manage_report_formats.c

@@ -672,6 +672,11 @@ sync_report_formats_with_feed ()
   GDir *dir;
   const gchar *report_format_path;
 
+  /* Test if base feed directory exists */
+
+  if (manage_gvmd_data_feed_dir_exists () == FALSE)
+    return 0;
+
   /* Setup owner. */
 
   setting_value (SETTING_UUID_FEED_IMPORT_OWNER, &current_credentials.uuid);